RESOLVED FIXED137499
[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds 
https://bugs.webkit.org/show_bug.cgi?id=137499
Summary [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator ...
Daniel Bates
Reported 2014-10-07 13:39:29 PDT
Currently run-webkit-tests only honors the TestExpectation file for 32-bit iOS Simulator builds of iOS WebKit. We should teach it to honor TestExpectation for 64-bit iOS Simulator builds of iOS WebKit. Once we honor the TestExpectation file for 64-bit builds we can look to rebaseline the iOS Simulator layout test results.
Attachments
Patch (3.40 KB, patch)
2014-10-07 13:40 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-10-07 13:40:54 PDT
Created attachment 239431 [details] Patch
Daniel Bates
Comment 2 2014-10-07 13:51:56 PDT
I didn't write a unit test for this change since the code in class IOSSimulatorPort represents port-specific configuration settings, which is subject to change (maybe it will not change often and hence it would be good to write a test?). Let me know if it's preferred to add a unit test for such a change.
WebKit Commit Bot
Comment 3 2014-10-07 14:35:14 PDT
Comment on attachment 239431 [details] Patch Clearing flags on attachment: 239431 Committed r174406: <http://trac.webkit.org/changeset/174406>
WebKit Commit Bot
Comment 4 2014-10-07 14:35:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.