Bug 137499 - [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
Summary: [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
Depends on:
Reported: 2014-10-07 13:39 PDT by Daniel Bates
Modified: 2014-10-07 14:35 PDT (History)
6 users (show)

See Also:

Patch (3.40 KB, patch)
2014-10-07 13:40 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-10-07 13:39:29 PDT
Currently run-webkit-tests only honors the TestExpectation file for 32-bit iOS Simulator builds of iOS WebKit. We should teach it to honor TestExpectation for 64-bit iOS Simulator builds of iOS WebKit. Once we honor the TestExpectation file for 64-bit builds we can look to rebaseline the iOS Simulator layout test results.
Comment 1 Daniel Bates 2014-10-07 13:40:54 PDT
Created attachment 239431 [details]
Comment 2 Daniel Bates 2014-10-07 13:51:56 PDT
I didn't write a unit test for this change since the code in class IOSSimulatorPort represents port-specific configuration settings, which is subject to change (maybe it will not change often and hence it would be good to write a test?). Let me know if it's preferred to add a unit test for such a change.
Comment 3 WebKit Commit Bot 2014-10-07 14:35:14 PDT
Comment on attachment 239431 [details]

Clearing flags on attachment: 239431

Committed r174406: <http://trac.webkit.org/changeset/174406>
Comment 4 WebKit Commit Bot 2014-10-07 14:35:18 PDT
All reviewed patches have been landed.  Closing bug.