Bug 137486 – [GTK] Minibrowser : Add home buton and keyboard support for home page load

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Rohit]

Currently no keyboard support or home button exists for home page load in GTK Minibrowser. Add home button and keyboard support for home page load using 'Alt' + 'Home' keys.

[Rohit]

Created attachment 239409 [details]
Patch

[Philippe Normand]

Comment on attachment 239409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239409&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:551
> +    webkit_web_view_load_uri(window->webView, "http://www.webkitgtk.org/");

I think this URL is hardcoded somewhere else already, right? Would be good to make it a #define

[Rohit]

Created attachment 239790 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 239790 [details]
Patch

Rejecting attachment 239790 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 239790 [details]
Patch

Clearing flags on attachment: 239790

Committed r174679: <http://trac.webkit.org/changeset/174679>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.