Bug 137486 - [GTK] Minibrowser : Add home buton and keyboard support for home page load
Summary: [GTK] Minibrowser : Add home buton and keyboard support for home page load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 06:26 PDT by Rohit
Modified: 2014-10-14 03:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.67 KB, patch)
2014-10-07 06:33 PDT, Rohit
no flags Details | Formatted Diff | Diff
Patch (4.19 KB, patch)
2014-10-14 02:43 PDT, Rohit
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rohit 2014-10-07 06:26:14 PDT
Currently no keyboard support or home button exists for home page load in GTK Minibrowser. Add home button and keyboard support for home page load using 'Alt' + 'Home' keys.
Comment 1 Rohit 2014-10-07 06:33:34 PDT
Created attachment 239409 [details]
Patch
Comment 2 Philippe Normand 2014-10-14 01:51:36 PDT
Comment on attachment 239409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239409&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:551
> +    webkit_web_view_load_uri(window->webView, "http://www.webkitgtk.org/");

I think this URL is hardcoded somewhere else already, right? Would be good to make it a #define
Comment 3 Rohit 2014-10-14 02:43:37 PDT
Created attachment 239790 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-14 02:49:06 PDT
Comment on attachment 239790 [details]
Patch

Rejecting attachment 239790 [details] from commit-queue.

kumar.rohit@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2014-10-14 03:49:10 PDT
Comment on attachment 239790 [details]
Patch

Clearing flags on attachment: 239790

Committed r174679: <http://trac.webkit.org/changeset/174679>
Comment 6 WebKit Commit Bot 2014-10-14 03:49:13 PDT
All reviewed patches have been landed.  Closing bug.