RESOLVED FIXED 137484
Remove build warnings in Hashmap API tests 
https://bugs.webkit.org/show_bug.cgi?id=137484
Summary Remove build warnings in Hashmap API tests
Tanay
Reported 2014-10-07 05:47:05 PDT
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:450:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:472:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingMoveKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:494:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:559:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry); ^ /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetUsingReleaseKeyAlreadyPresent_Test::TestBody()’: /home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:580:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null] EXPECT_EQ(false, addResult.isNewEntry);
Attachments
Patch (2.68 KB, patch)
2014-10-07 05:53 PDT, Tanay 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tanay
Comment 1 2014-10-07 05:53:48 PDT
Created attachment 239407 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-07 22:36:32 PDT
Comment on attachment 239407 [details] Patch Clearing flags on attachment: 239407 Committed r174418: <http://trac.webkit.org/changeset/174418>
WebKit Commit Bot
Comment 3 2014-10-07 22:36:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.