Bug 137484 - Remove build warnings in Hashmap API tests
Summary: Remove build warnings in Hashmap API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 05:47 PDT by Tanay
Modified: 2014-10-07 22:36 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2014-10-07 05:53 PDT, Tanay 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tanay 2014-10-07 05:47:05 PDT 
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:450:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
         EXPECT_EQ(false, addResult.isNewEntry);
                                                                                                                                                                  ^
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingReleaseKeyAlreadyPresent_Test::TestBody()’:
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:472:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
         EXPECT_EQ(false, addResult.isNewEntry);
                                                                                                                                                                  ^
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_AddUsingMoveKeyAlreadyPresent_Test::TestBody()’:
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:494:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
         EXPECT_EQ(false, addResult.isNewEntry);
                                                                                                                                                                  ^
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetKeyAlreadyPresent_Test::TestBody()’:
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:559:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
         EXPECT_EQ(false, addResult.isNewEntry);
                                                                                                                                                                  ^
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: In member function ‘virtual void TestWebKitAPI::WTF_HashMap_RefPtrKey_SetUsingReleaseKeyAlreadyPresent_Test::TestBody()’:
/home/tanay.c/webkit-tar/webkit/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:580:162: warning: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Wconversion-null]
         EXPECT_EQ(false, addResult.isNewEntry);
Comment 1 Tanay 2014-10-07 05:53:48 PDT 
Created attachment 239407 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-07 22:36:32 PDT 
Comment on attachment 239407 [details]
Patch

Clearing flags on attachment: 239407

Committed r174418: <http://trac.webkit.org/changeset/174418>
Comment 3 WebKit Commit Bot 2014-10-07 22:36:34 PDT 
All reviewed patches have been landed.  Closing bug.