Bug 137401 - [CSS Font Loading] Decrement the font loading count before notifying callbacks
Summary: [CSS Font Loading] Decrement the font loading count before notifying callbacks
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on:
Blocks: 135390
  Show dependency treegraph
Reported: 2014-10-03 13:51 PDT by Bear Travis
Modified: 2014-10-09 12:32 PDT (History)
1 user (show)

See Also:

Initial Patch (3.16 KB, patch)
2014-10-03 16:35 PDT, Bear Travis
ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2014-10-03 13:51:44 PDT
Comment 1 Bear Travis 2014-10-03 16:13:48 PDT
The font loader currently decrements the number of fonts loading after notifying callbacks. This means that the document.fonts.loading will return true when accessed within a callback for document.fonts.loadFont.

We should instead decrement the font loading count before calling callbacks.

This caused the above test failure when the number of fonts loading from JS was added to the loading() test.
Comment 2 Bear Travis 2014-10-03 16:35:10 PDT
Created attachment 239253 [details]
Initial Patch
Comment 3 WebKit Commit Bot 2014-10-09 11:46:27 PDT
Comment on attachment 239253 [details]
Initial Patch

Rejecting attachment 239253 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 239253, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/FontLoader.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1392.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6541415739817984
Comment 4 Bear Travis 2014-10-09 12:32:18 PDT
Not sure of the hiccup, but this landed in http://trac.webkit.org/changeset/174515.