Bug 137401 – [CSS Font Loading] Decrement the font loading count before notifying callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

http/tests/webfont/fontloader-loading-attribute.html

[Bear Travis]

The font loader currently decrements the number of fonts loading after notifying callbacks. This means that the document.fonts.loading will return true when accessed within a callback for document.fonts.loadFont.

We should instead decrement the font loading count before calling callbacks.

This caused the above test failure when the number of fonts loading from JS was added to the loading() test.

[Bear Travis]

Created attachment 239253 [details]
Initial Patch

[WebKit Commit Bot]

Comment on attachment 239253 [details]
Initial Patch

Rejecting attachment 239253 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 239253, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/FontLoader.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1392.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6541415739817984

[Bear Travis]

Not sure of the hiccup, but this landed in http://trac.webkit.org/changeset/174515.