Bug 137248 - Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
Summary: Web Inspector: [GTK] Missing icons and enhancing the proportion and visibilit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andres Gomez Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 02:59 PDT by Andres Gomez Garcia
Modified: 2014-10-02 03:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.11 MB, patch)
2014-09-30 03:28 PDT, Andres Gomez Garcia 		no flags Details | Formatted Diff | Diff
Updated patch (1.10 MB, patch)
2014-10-01 02:46 PDT, Andres Gomez Garcia 		no flags Details | Formatted Diff | Diff
WebInspector icons before the patch (301.32 KB, image/png)
2014-10-01 02:47 PDT, Andres Gomez Garcia 		no flags Details
WebInspector icons after the patch (260.23 KB, image/png)
2014-10-01 02:47 PDT, Andres Gomez Garcia 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gomez Garcia 2014-09-30 02:59:38 PDT 
After fixing bug 136632, there are still some icons missing.

In addition, some of the new ones are to light to be understood, like many of the DOM elements.

Finally, the proportion of some icons, specially the ones in the navigator bar, is not correct. Some are smaller/bigger than others, unlike in the Apple version. This could be enhanced.
Comment 1 Andres Gomez Garcia 2014-09-30 03:28:21 PDT 
Created attachment 238920 [details]
Patch
Comment 2 Andres Gomez Garcia 2014-10-01 02:46:33 PDT 
Created attachment 239013 [details]
Updated patch

Removed the PDF icon. I will open a new bug for replacing it with a SVG version.
Comment 3 Andres Gomez Garcia 2014-10-01 02:47:10 PDT 
Created attachment 239014 [details]
WebInspector icons before the patch
Comment 4 Andres Gomez Garcia 2014-10-01 02:47:35 PDT 
Created attachment 239015 [details]
WebInspector icons after the patch
Comment 5 Andres Gomez Garcia 2014-10-01 03:05:57 PDT 
Opened bug 137296 for the remaining PDF icon.
Comment 6 Carlos Garcia Campos 2014-10-02 03:19:54 PDT 
Comment on attachment 239013 [details]
Updated patch

This requires a clean build in the bots
Comment 7 WebKit Commit Bot 2014-10-02 03:57:36 PDT 
Comment on attachment 239013 [details]
Updated patch

Clearing flags on attachment: 239013

Committed r174207: <http://trac.webkit.org/changeset/174207>
Comment 8 WebKit Commit Bot 2014-10-02 03:57:39 PDT 
All reviewed patches have been landed.  Closing bug.