Bug 137237 - Web Inspector: support better git diff of localizedStrings.js
Summary: Web Inspector: support better git diff of localizedStrings.js
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Keywords: DoNotImportToRadar
: 137238 (view as bug list)
Depends on:
Reported: 2014-09-29 16:12 PDT by Timothy Hatcher
Modified: 2015-02-13 11:57 PST (History)
7 users (show)

See Also:

Patch (1.16 KB, patch)
2014-09-29 16:14 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-09-29 16:12:34 PDT
Git diffs localizedStrings.js as binary. We can improve that with a .gitattributes config file.
Comment 1 Timothy Hatcher 2014-09-29 16:14:33 PDT
Created attachment 238893 [details]
Comment 2 Timothy Hatcher 2014-09-29 16:15:54 PDT
*** Bug 137238 has been marked as a duplicate of this bug. ***
Comment 3 Joseph Pecoraro 2014-09-29 17:57:54 PDT
Can we just make it a UTF-8 file like our .strings files?
Comment 4 Timothy Hatcher 2015-02-10 09:47:11 PST
I don't know if the Apple tools support UTF-8 for JS Strings yet.
Comment 5 Joseph Pecoraro 2015-02-13 11:13:27 PST
Comment on attachment 238893 [details]

r=me, but it would be great if we could just convert the file.
Comment 6 WebKit Commit Bot 2015-02-13 11:57:54 PST
Comment on attachment 238893 [details]

Clearing flags on attachment: 238893

Committed r180067: <http://trac.webkit.org/changeset/180067>
Comment 7 WebKit Commit Bot 2015-02-13 11:57:59 PST
All reviewed patches have been landed.  Closing bug.