RESOLVED FIXED 137237
Web Inspector: support better git diff of localizedStrings.js 
https://bugs.webkit.org/show_bug.cgi?id=137237
Summary Web Inspector: support better git diff of localizedStrings.js
Timothy Hatcher
Reported 2014-09-29 16:12:34 PDT
Git diffs localizedStrings.js as binary. We can improve that with a .gitattributes config file.
Attachments
Patch (1.16 KB, patch)
2014-09-29 16:14 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-09-29 16:14:33 PDT
Created attachment 238893 [details] Patch
Timothy Hatcher
Comment 2 2014-09-29 16:15:54 PDT
*** Bug 137238 has been marked as a duplicate of this bug. ***
Joseph Pecoraro
Comment 3 2014-09-29 17:57:54 PDT
Can we just make it a UTF-8 file like our .strings files?
Timothy Hatcher
Comment 4 2015-02-10 09:47:11 PST
I don't know if the Apple tools support UTF-8 for JS Strings yet.
Joseph Pecoraro
Comment 5 2015-02-13 11:13:27 PST
Comment on attachment 238893 [details] Patch r=me, but it would be great if we could just convert the file.
WebKit Commit Bot
Comment 6 2015-02-13 11:57:54 PST
Comment on attachment 238893 [details] Patch Clearing flags on attachment: 238893 Committed r180067: <http://trac.webkit.org/changeset/180067>
WebKit Commit Bot
Comment 7 2015-02-13 11:57:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.