Bug 137197 - Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
Summary: Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-28 11:54 PDT by Myles C. Maxfield
Modified: 2014-09-28 20:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.80 KB, patch)
2014-09-28 12:01 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2014-09-28 15:06 PDT, Myles C. Maxfield 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-09-28 11:54:01 PDT 
Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
Comment 1 Myles C. Maxfield 2014-09-28 12:01:07 PDT 
Created attachment 238819 [details]
Patch
Comment 2 Myles C. Maxfield 2014-09-28 15:06:15 PDT 
Created attachment 238824 [details]
Patch
Comment 3 Alexey Proskuryakov 2014-09-28 16:50:10 PDT 
Comment on attachment 238824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review

> Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30
> +#else

This should not be an else, we should forward declare functions unconditionally. 

Also, I think the the file name should end with SPI by convention.
Comment 4 Myles C. Maxfield 2014-09-28 19:36:37 PDT 
Comment on attachment 238824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review

>> Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30
>> +#else
> 
> This should not be an else, we should forward declare functions unconditionally. 
> 
> Also, I think the the file name should end with SPI by convention.

Done.

Done.
Comment 5 Myles C. Maxfield 2014-09-28 20:43:23 PDT 
http://trac.webkit.org/changeset/174052