RESOLVED FIXED137197
Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars() 
https://bugs.webkit.org/show_bug.cgi?id=137197
Summary Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
Myles C. Maxfield
Reported 2014-09-28 11:54:01 PDT
Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
Attachments
Patch (14.80 KB, patch)
2014-09-28 12:01 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (14.81 KB, patch)
2014-09-28 15:06 PDT, Myles C. Maxfield 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-09-28 12:01:07 PDT
Created attachment 238819 [details] Patch
Myles C. Maxfield
Comment 2 2014-09-28 15:06:15 PDT
Created attachment 238824 [details] Patch
Alexey Proskuryakov
Comment 3 2014-09-28 16:50:10 PDT
Comment on attachment 238824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review > Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30 > +#else This should not be an else, we should forward declare functions unconditionally. Also, I think the the file name should end with SPI by convention.
Myles C. Maxfield
Comment 4 2014-09-28 19:36:37 PDT
Comment on attachment 238824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238824&action=review >> Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupport.h:30 >> +#else > > This should not be an else, we should forward declare functions unconditionally. > > Also, I think the the file name should end with SPI by convention. Done. Done.
Myles C. Maxfield
Comment 5 2014-09-28 20:43:23 PDT
http://trac.webkit.org/changeset/174052
Note You need to log in before you can comment on or make changes to this bug.