Bug 137174 – Automatically generate template specializations for most Elements

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Currently, the template specializations to make is<>() / downcast<>() work for HTML/SVG/MathML elements are only generated if "generateTypeHelpers" parameter is explicitly specified for the corresponding tag name in the *Tags.in file. We are however able to generate the template specializations for most types so I would propose we generate those helpers by default.

One case we cannot generate the specialization is when a class is associated to several tag names but the make_names.pl script could easily detect this and skip those classes.

[Chris Dumez]

Created attachment 238768 [details]
WIP Patch

[Chris Dumez]

Created attachment 238781 [details]
Patch

[WebKit Commit Bot]

Attachment 238781 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGAnimateElement.h:82:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 238781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238781&action=review

Looks great.

> Source/WebCore/svg/SVGAnimateElement.h:35
> +class SVGAnimateElementBase : public SVGAnimationElement {

I think we should consider moving SVGAnimateElementBase to its own separate source file.

[Chris Dumez]

Created attachment 238833 [details]
Patch

[WebKit Commit Bot]

Attachment 238833 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGAnimateElementBase.h:81:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 34 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238833 [details]
Patch

Clearing flags on attachment: 238833

Committed r174050: <http://trac.webkit.org/changeset/174050>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.