Bug 137112 - Require Python 2.7 version
Summary: Require Python 2.7 version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-25 02:03 PDT by Éva Balázsfalvi
Modified: 2014-09-30 09:37 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2014-09-25 02:06 PDT, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-09-25 02:03:52 PDT
Discussion about requiring python 2.7 for build and test machines, without any objection:
https://lists.webkit.org/pipermail/webkit-dev/2014-September/026863.html
Comment 1 Éva Balázsfalvi 2014-09-25 02:06:52 PDT
Created attachment 238651 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-09-25 02:50:32 PDT
Comment on attachment 238651 [details]
Patch

The patch looks good to me, so r=me.

But it seems the Windows EWS isn't ready for this patch yet:
"Unsupported Python version: WebKit only supports 2.7.x, and you're running 2.6.8."
So we shouldn't land it until Windows bots are ready for it.

Brent said that the update of Windows buildbots and EWS would happen on
17th of september - https://lists.webkit.org/pipermail/webkit-dev/2014-September/026846.html
Brent, any news about the update?
Comment 3 Csaba Osztrogonác 2014-09-30 05:15:52 PDT
Comment on attachment 238651 [details]
Patch

The win bot is green now, so let's try it.
Comment 4 WebKit Commit Bot 2014-09-30 05:50:52 PDT
Comment on attachment 238651 [details]
Patch

Clearing flags on attachment: 238651

Committed r174102: <http://trac.webkit.org/changeset/174102>
Comment 5 WebKit Commit Bot 2014-09-30 05:50:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2014-09-30 09:37:57 PDT
Great work, thanks!