RESOLVED FIXED 136946
REGRESSION(r173631): It broke the !ENABLE(VIDEO) build 
https://bugs.webkit.org/show_bug.cgi?id=136946
Summary REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
Csaba Osztrogonác
Reported 2014-09-19 02:22:39 PDT
build log: /home/webkit/WebKit/Source/WebCore/page/DragController.cpp: In member function 'bool WebCore::DragController::startDrag(WebCore::Frame&, const WebCore::DragState&, WebCore::DragOperation, const WebCore::PlatformMouseEvent&, const WebCore::IntPoint&)': /home/webkit/WebKit/Source/WebCore/page/DragController.cpp:726:43: error: 'class WebCore::Element' has no member named 'isMediaElement'
Attachments
Patch (1.69 KB, patch)
2014-09-19 03:47 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2014-09-22 04:14 PDT, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-09-19 03:47:25 PDT
Created attachment 238369 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-09-19 08:50:31 PDT
Comment on attachment 238369 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238369&action=review > Source/WebCore/page/DragController.cpp:726 > + bool includeShadowDOM = true; Shouldn't this default to false?
Éva Balázsfalvi
Comment 3 2014-09-22 04:14:08 PDT
Created attachment 238476 [details] Patch
WebKit Commit Bot
Comment 4 2014-09-22 08:01:04 PDT
Comment on attachment 238476 [details] Patch Clearing flags on attachment: 238476 Committed r173836: <http://trac.webkit.org/changeset/173836>
WebKit Commit Bot
Comment 5 2014-09-22 08:01:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.