Bug 136871 – REGRESSION(r173670): Creates layering violation (Requested by enrica on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

http://trac.webkit.org/changeset/173670 broke the build:
Creates layering violation (Requested by enrica on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 238214 [details]
ROLLOUT of r173670

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Attachment 238214 [details] did not pass style-queue:


ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:210:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:211:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:247:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:248:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:249:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:250:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:251:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:255:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:256:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:257:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:347:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:382:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:410:  Extra space before )  [whitespace/parens] [2]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:477:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:478:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:479:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:480:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:481:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:499:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:502:  The parameter name "block" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:513:  The parameter name "list" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:513:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:626:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:724:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:724:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:765:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:768:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:769:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:770:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:771:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:772:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:773:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:812:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:824:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:986:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1236:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1236:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1238:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1240:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1561:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1758:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1760:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1822:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1882:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1918:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:1946:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2038:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2088:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2171:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2175:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2176:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2177:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2213:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2214:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2220:  More than one command on the same line in if  [whitespace/parens] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2279:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/editing/cocoa/HTMLConverter.mm:2344:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 57 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

Comment on attachment 238214 [details]
ROLLOUT of r173670

Clearing flags on attachment: 238214

Committed r173679: <http://trac.webkit.org/changeset/173679>

[Enrica Casucci]

All reviewed patches have been landed.  Closing bug.