Bug 136865 - Two editing/spelling layout tests are not as robust as they could be
Summary: Two editing/spelling layout tests are not as robust as they could be
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-16 13:29 PDT by Myles C. Maxfield
Modified: 2014-12-27 08:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2014-09-16 13:30 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2014-09-16 13:36 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-09-16 13:29:16 PDT 
editing/spelling/spelling-with-punctuation-selection.html is not as robust as it could be
Comment 1 Myles C. Maxfield 2014-09-16 13:30:26 PDT 
Created attachment 238198 [details]
Patch
Comment 2 Myles C. Maxfield 2014-09-16 13:36:06 PDT 
Created attachment 238201 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-09-16 13:51:55 PDT 
Comment on attachment 238201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238201&action=review

> LayoutTests/ChangeLog:3
> +        Two editing/spelling layout tests are not as robust as they could be

This would be better as "Make spelling tests more reliable by using a word that is misspelled in all English variants" or something.
Comment 4 Myles C. Maxfield 2014-09-16 15:37:13 PDT 
http://trac.webkit.org/changeset/173674
Comment 5 Myles C. Maxfield 2014-12-27 08:16:29 PST 
It looks like this is supposed to be mocked, so this patch shouldn't have worked. See DumpRenderTree.mm

@"wellcome": @"welcome",

We should figure out why the mock didn't work.