Bug 136862 - [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
Summary: [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/rele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-16 12:37 PDT by Daniel Bates
Modified: 2014-09-16 15:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.69 KB, patch)
2014-09-16 12:41 PDT, Daniel Bates
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-09-16 12:37:03 PDT
Add a suffix to the iOS WebKitSystemInterface name that includes the SDK name and version.
Comment 1 Daniel Bates 2014-09-16 12:41:43 PDT
Created attachment 238194 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2014-09-16 13:20:26 PDT
Comment on attachment 238194 [details]
Patch

r=me, but I think there is a change that needs to be made to Tools/Scripts/copy-webkitlibraries-to-product-directory to make sure we copy the correct libWebKitSystemInterfaceIOS*.a when building for the iOS Simulator.
Comment 3 Daniel Bates 2014-09-16 13:51:39 PDT
(In reply to comment #2)
> (From update of attachment 238194 [details])
> [...] I think there is a change that needs to be made to Tools/Scripts/copy-webkitlibraries-to-product-directory to make sure we copy the correct libWebKitSystemInterfaceIOS*.a when building for the iOS Simulator.

I plan to do this in another bug.
Comment 4 Daniel Bates 2014-09-16 15:30:05 PDT
Committed r173673: <http://trac.webkit.org/changeset/173673>