WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136821
Remove ORWT related crufts from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=136821
Summary
Remove ORWT related crufts from webkitdirs.pm
Tibor Mészáros
Reported
2014-09-15 05:31:59 PDT
old-run-webkit-tests was removed from trunk by
http://trac.webkit.org/changeset/171967
, so we can remove ORWT related crufts from webkitdirs.pm.
Attachments
Patch
(2.82 KB, patch)
2014-09-15 05:34 PDT
,
Tibor Mészáros
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tibor Mészáros
Comment 1
2014-09-15 05:34:37 PDT
Created
attachment 238122
[details]
Patch This patch will removed ORWT related crufts from webkitdirs.pm.
Alexey Proskuryakov
Comment 2
2014-09-15 20:13:13 PDT
Comment on
attachment 238122
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238122&action=review
r=me assuming that webkitperl tests passed (test-webkitperl). EWS doesn't run these.
> Tools/Scripts/webkitdirs.pm:-1184 > -sub isPerianInstalled()
Interesting - there was recently a conjecture that tests fail on some machines because of Perian. Perhaps we should start checking for it in nrwt.
WebKit Commit Bot
Comment 3
2014-09-15 20:50:22 PDT
Comment on
attachment 238122
[details]
Patch Clearing flags on attachment: 238122 Committed
r173647
: <
http://trac.webkit.org/changeset/173647
>
WebKit Commit Bot
Comment 4
2014-09-15 20:50:25 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug