Bug 136781 - [GStreamer] don't send transferMode HTTP header
Summary: [GStreamer] don't send transferMode HTTP header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gomez Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-12 07:55 PDT by Philippe Normand
Modified: 2014-09-15 01:08 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.84 KB, patch)
2014-09-12 15:34 PDT, Andres Gomez Garcia
no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2014-09-12 15:52 PDT, Andres Gomez Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2014-09-12 07:55:23 PDT
Support for this header was removed from souphttpsrc in 2012, it seems...  https://bugzilla.gnome.org/show_bug.cgi?id=676020
Comment 1 Andres Gomez Garcia 2014-09-12 15:34:46 PDT
Created attachment 238068 [details]
Patch
Comment 2 Andres Gomez Garcia 2014-09-12 15:52:26 PDT
Created attachment 238070 [details]
Patch
Comment 3 Sergio Villar Senin 2014-09-15 00:17:52 PDT
I'll let Phil review this but I guess we need some test to check the headers we send.
Comment 4 Philippe Normand 2014-09-15 00:32:34 PDT
Comment on attachment 238070 [details]
Patch

Loooks good, thanks! I'm not really sure a test is needed for this though.
Comment 5 WebKit Commit Bot 2014-09-15 01:08:23 PDT
Comment on attachment 238070 [details]
Patch

Clearing flags on attachment: 238070

Committed r173614: <http://trac.webkit.org/changeset/173614>
Comment 6 WebKit Commit Bot 2014-09-15 01:08:27 PDT
All reviewed patches have been landed.  Closing bug.