Bug 136764 - Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
Summary: Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 16:00 PDT by Chris Dumez
Modified: 2014-09-14 15:19 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2014-09-11 16:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.70 KB, patch)
2014-09-11 16:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.71 KB, patch)
2014-09-11 16:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-11 16:00:03 PDT 
Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode in argument. This one does not bring any performance improvement because nextSibling() is defined on Node and nextAncestorSibling() takes a Node in argument.
Comment 1 Chris Dumez 2014-09-11 16:11:15 PDT 
Created attachment 237994 [details]
Patch
Comment 2 Chris Dumez 2014-09-11 16:15:20 PDT 
Comment on attachment 237994 [details]
Patch

I'll get rid of the one on ElementTraversal as well in the same patch.
Comment 3 Chris Dumez 2014-09-11 16:24:10 PDT 
Created attachment 237995 [details]
Patch
Comment 4 Chris Dumez 2014-09-11 16:37:26 PDT 
Created attachment 237997 [details]
Patch
Comment 5 Darin Adler 2014-09-14 12:35:37 PDT 
Comment on attachment 237997 [details]
Patch

Seems fine, but the fact that we can’t easily test is unfortunate.
Comment 6 WebKit Commit Bot 2014-09-14 15:19:26 PDT 
Comment on attachment 237997 [details]
Patch

Clearing flags on attachment: 237997

Committed r173607: <http://trac.webkit.org/changeset/173607>
Comment 7 WebKit Commit Bot 2014-09-14 15:19:31 PDT 
All reviewed patches have been landed.  Closing bug.