RESOLVED FIXED 136764
Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode 
https://bugs.webkit.org/show_bug.cgi?id=136764
Summary Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
Chris Dumez
Reported 2014-09-11 16:00:03 PDT
Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode in argument. This one does not bring any performance improvement because nextSibling() is defined on Node and nextAncestorSibling() takes a Node in argument.
Attachments
Patch (3.91 KB, patch)
2014-09-11 16:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.70 KB, patch)
2014-09-11 16:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.71 KB, patch)
2014-09-11 16:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-09-11 16:11:15 PDT
Created attachment 237994 [details] Patch
Chris Dumez
Comment 2 2014-09-11 16:15:20 PDT
Comment on attachment 237994 [details] Patch I'll get rid of the one on ElementTraversal as well in the same patch.
Chris Dumez
Comment 3 2014-09-11 16:24:10 PDT
Created attachment 237995 [details] Patch
Chris Dumez
Comment 4 2014-09-11 16:37:26 PDT
Created attachment 237997 [details] Patch
Darin Adler
Comment 5 2014-09-14 12:35:37 PDT
Comment on attachment 237997 [details] Patch Seems fine, but the fact that we can’t easily test is unfortunate.
WebKit Commit Bot
Comment 6 2014-09-14 15:19:26 PDT
Comment on attachment 237997 [details] Patch Clearing flags on attachment: 237997 Committed r173607: <http://trac.webkit.org/changeset/173607>
WebKit Commit Bot
Comment 7 2014-09-14 15:19:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.