Bug 136737 - CanvasRenderingContext2D should update the computed style while setting the font
Summary: CanvasRenderingContext2D should update the computed style while setting the font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 01:55 PDT by Vivek Galatage
Modified: 2014-09-12 17:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.71 KB, patch)
2014-09-11 02:08 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2014-09-11 01:55:13 PDT 
Before accessing the computed style for populating 'font' property of CanvasRenderingContext2D
we have to make sure we have a up-to-date computed style to avoid any stale reference.
Comment 1 Vivek Galatage 2014-09-11 02:08:42 PDT 
Created attachment 237945 [details]
Patch
Comment 2 Vivek Galatage 2014-09-11 02:12:37 PDT 
Please take a look, thank you.
Comment 3 Vivek Galatage 2014-09-11 08:37:23 PDT 
Here is the jsfiddle test: http://jsfiddle.net/j424ygda/
Comment 4 Vivek Galatage 2014-09-12 11:32:42 PDT 
Friendly ping!
Comment 5 WebKit Commit Bot 2014-09-12 17:07:19 PDT 
Comment on attachment 237945 [details]
Patch

Clearing flags on attachment: 237945

Committed r173591: <http://trac.webkit.org/changeset/173591>
Comment 6 WebKit Commit Bot 2014-09-12 17:07:23 PDT 
All reviewed patches have been landed.  Closing bug.