Bug 136716 – fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

run-webkit-tests -v --no-retry -g --additional-env-var="JSC_slowPathAllocsBetweenGCs=1" fast/forms/submit-to-blank-multiple-times.html

Crashes every time.
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x00000001071c77ba WTFCrash + 42
1   DumpRenderTree                	0x0000000106664bd4 -[UIDelegate webView:createWebViewWithRequest:] + 132 (UIDelegate.mm:166)
2   com.apple.WebKitLegacy        	0x0000000111b5449f -[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:] + 175 (WebDefaultUIDelegate.m:73)
3   com.apple.CoreFoundation      	0x00007fff852bef8c __invoking___ + 140
4   com.apple.CoreFoundation      	0x00007fff852bede2 -[NSInvocation invoke] + 290
5   com.apple.CoreFoundation      	0x00007fff8535daa6 -[NSInvocation invokeWithTarget:] + 54
6   com.apple.WebKitLegacy        	0x0000000111c6863c -[_WebSafeForwarder forwardInvocation:] + 348 (WebView.mm:4559)
7   com.apple.CoreFoundation      	0x00007fff853304d6 ___forwarding___ + 518
8   com.apple.CoreFoundation      	0x00007fff85330248 _CF_forwarding_prep_0 + 120
9   com.apple.WebKitLegacy        	0x0000000111b7de14 WebFrameLoaderClient::dispatchCreatePage(WebCore::NavigationAction const&) + 148 (WebFrameLoaderClient.mm:846)
10  com.apple.WebCore             	0x000000010b1aa29b WebCore::FrameLoader::continueLoadAfterNewWindowPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, WTF::String const&, WebCore::NavigationAction const&, bool, WebCore::AllowNavigationToInvalidURL) + 139 (FrameLoader.cpp:2977)
11  com.apple.WebCore             	0x000000010b1b491f WebCore::FrameLoader::loadURL(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::LockHistory, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_0::operator()(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, WTF::String const&, WebCore::NavigationAction const&, bool) const + 127 (FrameLoader.cpp:1292)
12  com.apple.WebCore             	0x000000010b1b4885 std::__1::__function::__func<WebCore::FrameLoader::loadURL(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::LockHistory, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_0, std::__1::allocator<WebCore::FrameLoader::loadURL(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::LockHistory, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::Event>, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_0>, void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, WTF::String const&, WebCore::NavigationAction const&, bool)>::operator()(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>&&, WTF::String const&, WebCore::NavigationAction const&, bool&&) + 341 (__functional_base:413)

Not yet sure if this is a WebKit or a DumpRenderTree bug.

<rdar://problem/18296930>

[Alexey Proskuryakov]

Skipped the test in <http://trac.webkit.org/r173491>.

[Alexey Proskuryakov]

This is just a test bug - JSC_slowPathAllocsBetweenGCs makes it slow, so it fires a timeout that's meant to clean up, but instead causes trouble.

[Alexey Proskuryakov]

Created attachment 237909 [details]
proposed fix

[Alexey Proskuryakov]

Created attachment 237910 [details]
with a proper bug title

[Build Bot]

Comment on attachment 237910 [details]
with a proper bug title

Attachment 237910 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4673395228672000

New failing tests:
http/tests/media/video-throttled-load-metadata.html
http/tests/media/video-served-as-text.html
http/tests/media/video-error-does-not-exist.html

[Build Bot]

Created attachment 237925 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[WebKit Commit Bot]

Comment on attachment 237910 [details]
with a proper bug title

Clearing flags on attachment: 237910

Committed r173556: <http://trac.webkit.org/changeset/173556>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.