WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136710
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
https://bugs.webkit.org/show_bug.cgi?id=136710
Summary
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Oliver Hunt
Reported
2014-09-10 12:47:00 PDT
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Attachments
Patch
(40.41 KB, patch)
2014-09-10 12:47 PDT
,
Oliver Hunt
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2014-09-10 12:47:29 PDT
Created
attachment 237898
[details]
Patch
WebKit Commit Bot
Comment 2
2014-09-10 12:48:55 PDT
Attachment 237898
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:66: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:67: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2014-09-10 13:27:09 PDT
Comment on
attachment 237898
[details]
Patch rs=me
Oliver Hunt
Comment 4
2014-09-10 14:52:19 PDT
Committed
r173490
: <
http://trac.webkit.org/changeset/173490
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug