Bug 136710 - Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Summary: Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 12:47 PDT by Oliver Hunt
Modified: 2014-09-10 14:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (40.41 KB, patch)
2014-09-10 12:47 PDT, Oliver Hunt 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-09-10 12:47:00 PDT 
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
Comment 1 Oliver Hunt 2014-09-10 12:47:29 PDT 
Created attachment 237898 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-10 12:48:55 PDT 
Attachment 237898 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:66:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/runtime/JSEnvironmentRecord.h:67:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-09-10 13:27:09 PDT 
Comment on attachment 237898 [details]
Patch

rs=me
Comment 4 Oliver Hunt 2014-09-10 14:52:19 PDT 
Committed r173490: <http://trac.webkit.org/changeset/173490>