Bug 136691 - Web Inspector: Eliminate typeof "undefined" checks
Summary: Web Inspector: Eliminate typeof "undefined" checks
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-09-09 18:29 PDT by Joseph Pecoraro
Modified: 2014-09-10 16:10 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (4.70 KB, patch)
2014-09-09 18:30 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-09 18:29:28 PDT
A long time ago, `undefined` could be re-assigned. Which could cause craziness comparing to undefined. That has not been the case for a while.

We can just convert:

    typeof foo === "undefined"


    foo === undefined
Comment 1 Joseph Pecoraro 2014-09-09 18:30:10 PDT
Created attachment 237876 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-09-10 15:41:29 PDT
Comment on attachment 237876 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237876

Committed r173494: <http://trac.webkit.org/changeset/173494>
Comment 3 WebKit Commit Bot 2014-09-10 15:41:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Brian Burg 2014-09-10 16:10:26 PDT
Comment on attachment 237876 [details]
[PATCH] Proposed Fix

Was this supposed to include a change to .eslintrc?