Bug 136660 - Web Inspector: Fix ESLint no-undef warnings
Summary: Web Inspector: Fix ESLint no-undef warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 20:21 PDT by Joseph Pecoraro
Modified: 2014-09-10 09:00 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.29 KB, patch)
2014-09-08 20:22 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-09-08 20:21:29 PDT 
ESLint emits a lot of no-undef warnings because we don't list all of our global utility functions (which we should probably namespace).

However these looked like some straight forward mistakes, and I'll follow up with a few other larger issues it catches.
Comment 1 Joseph Pecoraro 2014-09-08 20:22:11 PDT 
Created attachment 237834 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-09-10 09:00:35 PDT 
Comment on attachment 237834 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237834

Committed r173466: <http://trac.webkit.org/changeset/173466>
Comment 3 WebKit Commit Bot 2014-09-10 09:00:38 PDT 
All reviewed patches have been landed.  Closing bug.