Bug 136630 - [CSS Grid Layout] RenderGrid methods should take RenderBox references
Summary: [CSS Grid Layout] RenderGrid methods should take RenderBox references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2014-09-08 07:21 PDT by Sergio Villar Senin
Modified: 2014-10-15 04:44 PDT (History)
9 users (show)

See Also:


Attachments
Patch (24.90 KB, patch)
2014-09-08 07:29 PDT, Sergio Villar Senin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2014-09-08 07:21:22 PDT
[CSS Grid Layout] RenderGrid methods should take RenderBox references
Comment 1 Sergio Villar Senin 2014-09-08 07:29:17 PDT
Created attachment 237784 [details]
Patch
Comment 2 Darin Adler 2014-09-08 08:02:37 PDT
Comment on attachment 237784 [details]
Patch

Separate thought: Can the type be more specific than RenderBox?
Comment 3 Sergio Villar Senin 2014-09-09 03:31:09 PDT
(In reply to comment #2)
> (From update of attachment 237784 [details])
> Separate thought: Can the type be more specific than RenderBox?

I don't think so,  if I am not wrong any RenderBox can be a child.
Comment 4 Sergio Villar Senin 2014-09-09 04:39:59 PDT
Committed r173427: <http://trac.webkit.org/changeset/173427>