Bug 136624 - Fix 32-bit Mac build for new warnings
Summary: Fix 32-bit Mac build for new warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-08 03:21 PDT by Maciej Stachowiak
Modified: 2014-09-08 18:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.02 KB, patch)
2014-09-08 03:23 PDT, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2014-09-08 03:21:40 PDT
Fix 32-bit Mac build for new warnings
Comment 1 Maciej Stachowiak 2014-09-08 03:23:22 PDT
Created attachment 237776 [details]
Patch
Comment 2 Darin Adler 2014-09-08 09:24:56 PDT
Comment on attachment 237776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237776&action=review

> Source/WebKit/mac/Carbon/HIViewAdapter.m:49
> +

Looks like there’s an extra blank line here we could omit.
Comment 3 Jessie Berlin 2014-09-08 09:32:52 PDT
I fixed these this morning individually. I wish I had seen this patch first :(
Comment 4 Maciej Stachowiak 2014-09-08 13:13:55 PDT
I probably should have landed it without waiting for review.
Comment 5 Maciej Stachowiak 2014-09-08 18:46:29 PDT
Committed r173415: <http://trac.webkit.org/changeset/173415>