WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136624
Fix 32-bit Mac build for new warnings
https://bugs.webkit.org/show_bug.cgi?id=136624
Summary
Fix 32-bit Mac build for new warnings
Maciej Stachowiak
Reported
2014-09-08 03:21:40 PDT
Fix 32-bit Mac build for new warnings
Attachments
Patch
(10.02 KB, patch)
2014-09-08 03:23 PDT
,
Maciej Stachowiak
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2014-09-08 03:23:22 PDT
Created
attachment 237776
[details]
Patch
Darin Adler
Comment 2
2014-09-08 09:24:56 PDT
Comment on
attachment 237776
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=237776&action=review
> Source/WebKit/mac/Carbon/HIViewAdapter.m:49 > +
Looks like there’s an extra blank line here we could omit.
Jessie Berlin
Comment 3
2014-09-08 09:32:52 PDT
I fixed these this morning individually. I wish I had seen this patch first :(
Maciej Stachowiak
Comment 4
2014-09-08 13:13:55 PDT
I probably should have landed it without waiting for review.
Maciej Stachowiak
Comment 5
2014-09-08 18:46:29 PDT
Committed
r173415
: <
http://trac.webkit.org/changeset/173415
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug