Bug 136562 - [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled
Summary: [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP)...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
Depends on:
Reported: 2014-09-04 18:32 PDT by Pratik Solanki
Modified: 2014-09-05 13:25 PDT (History)
13 users (show)

See Also:

Patch (5.09 KB, patch)
2014-09-05 12:41 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-09-04 18:32:59 PDT
Build is broken after bug 136534 (r173272) because that change relies on a platform specific platformSuggestedFilename() method. I will be adding a stub one to fix the build but this needs to be implemented correctly.
Comment 1 Pratik Solanki 2014-09-04 18:36:42 PDT
Stub implementation landed in https://trac.webkit.org/r173301
Comment 2 Carlos Alberto Lopez Perez 2014-09-05 10:19:09 PDT
r173272 introduced two new layout test failures on the GTK port:

http/tests/download/basic-ascii.html [ Failure ]
http/tests/download/literal-utf-8.html [ Failure ]

Diffs here: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r173306%20%282554%29/http/tests/download/

I'm updating the GTK TestExpectations and assigning this bug to such failures since I think that fixing this bug will fix also both tests.
Comment 3 Carlos Alberto Lopez Perez 2014-09-05 11:26:21 PDT
r173272 has also caused failures on the GTK API tests:


$ Tools/Scripts/run-gtk-tests --verbose --release WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources
TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads... (pid=2457)
  /webkit2/Downloads/local-file:                                       OK
  /webkit2/Downloads/local-file-error:                                 OK
  /webkit2/Downloads/remote-file:                                      **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:172:void DownloadTest::checkDestinationAndDeleteFile(WebKitDownload*, const char*): assertion failed (destBasename.get() == expectedName): ("test.pdf" == "webkit-downloaded-file")
GTester: last random seed: R02S411e3b1c5da1feafced3b6bd5721a40f
  /webkit2/Downloads/remote-file-error:                                OK
  /webkit2/Downloads/policy-decision-download:                         OK
  /webkit2/WebKitWebView/download-uri:                                 OK
FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads
TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources... (pid=2548)
  /webkit2/WebKitWebView/resources:                                    OK
  /webkit2/WebKitWebView/history-cache:                                OK
  /webkit2/WebKitWebResource/loading:                                  OK
  /webkit2/WebKitWebResource/response:                                 OK
  /webkit2/WebKitWebResource/mime-type:                                OK
  /webkit2/WebKitWebResource/suggested-filename:                       **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:431:void testWebResourceSuggestedFilename(SingleResourceLoadTest*, gconstpointer): assertion failed (webkit_uri_response_get_suggested_filename(response) == "JavaScript.js"): (NULL == "JavaScript.js")
GTester: last random seed: R02Sa97354273c64dd60f7d30bb2ec4a95b7
  /webkit2/WebKitWebResource/active-uri:                               OK
  /webkit2/WebKitWebResource/get-data:                                 OK
  /webkit2/WebKitWebPage/send-request:                                 OK
FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources
Tests failed (2): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads, WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources

I'm assigning this bug also to such failures.
Comment 4 Carlos Alberto Lopez Perez 2014-09-05 11:44:28 PDT
Updated GTK TestExpectations and list of API Skipped tests on http://trac.webkit.org/changeset/173319
Comment 5 Carlos Alberto Lopez Perez 2014-09-05 12:41:00 PDT
Created attachment 237706 [details]
Comment 6 WebKit Commit Bot 2014-09-05 13:25:12 PDT
Comment on attachment 237706 [details]

Clearing flags on attachment: 237706

Committed r173331: <http://trac.webkit.org/changeset/173331>
Comment 7 WebKit Commit Bot 2014-09-05 13:25:17 PDT
All reviewed patches have been landed.  Closing bug.