Bug 136429 - [ARM] MacroAssembler generating incorrect code on ARM32 Traditional
Summary: [ARM] MacroAssembler generating incorrect code on ARM32 Traditional
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 108645
  Show dependency treegraph
Reported: 2014-09-01 09:15 PDT by Dániel Bátyai
Modified: 2014-09-02 10:01 PDT (History)
7 users (show)

See Also:

Patch (1.36 KB, patch)
2014-09-01 09:20 PDT, Dániel Bátyai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2014-09-01 09:15:54 PDT
At MacroAssemblerARM.h:945 we check if the value in reg is zero, but the 0 in cmp was being interpreted as r0 instead of a constant.
Comment 1 Dániel Bátyai 2014-09-01 09:20:53 PDT
Created attachment 237452 [details]

Changed test32 to use tst instead of cmp to check if reg is zero.
Comment 2 WebKit Commit Bot 2014-09-02 10:01:45 PDT
Comment on attachment 237452 [details]

Clearing flags on attachment: 237452

Committed r173179: <http://trac.webkit.org/changeset/173179>
Comment 3 WebKit Commit Bot 2014-09-02 10:01:50 PDT
All reviewed patches have been landed.  Closing bug.