Bug 136389 - Rename updatePreferredWidth to make it more explicit.
Summary: Rename updatePreferredWidth to make it more explicit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-29 14:20 PDT by zalan
Modified: 2014-08-29 19:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.92 KB, patch)
2014-08-29 14:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-08-29 14:20:33 PDT 
from:
static inline void updatePreferredWidth(LayoutUnit& preferredWidth, float& result)

to:
static inline LayoutUnit preferredWidth(LayoutUnit preferredWidth, float result)
Comment 1 zalan 2014-08-29 14:26:39 PDT 
Created attachment 237377 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-08-29 19:13:54 PDT 
Comment on attachment 237377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237377&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2984
> +                    minLogicalWidth = preferredWidth(minLogicalWidth, inlineMin);

It's correct to use fromFloatCeil() even though this is a "min" value?
Comment 3 WebKit Commit Bot 2014-08-29 19:55:12 PDT 
Comment on attachment 237377 [details]
Patch

Clearing flags on attachment: 237377

Committed r173134: <http://trac.webkit.org/changeset/173134>
Comment 4 WebKit Commit Bot 2014-08-29 19:55:14 PDT 
All reviewed patches have been landed.  Closing bug.