Bug 136353 - Web Inspector: Fix how Popover animates
Summary: Web Inspector: Fix how Popover animates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-28 15:31 PDT by Saam Barati
Modified: 2014-08-29 13:10 PDT (History)
5 users (show)

See Also:


Attachments
patch (8.23 KB, patch)
2014-08-28 16:37 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-08-28 15:31:34 PDT
- Currently, animations for Popover do glitchy animations with the anchor point.
- Also, popover::_animateFrame uses window.requestAnimationFrame instead which won't fire while paused in the debugger. This patch switches to setTimeout with a FIXME indicating it needs to
  be switched back when the inspector moves out of process.
- Also, there isn't a way to add new content and a new frame at the same time without animating between those steps.

This patch will solve all three problems.
Comment 1 Radar WebKit Bug Importer 2014-08-28 15:31:45 PDT
<rdar://problem/18167946>
Comment 2 Saam Barati 2014-08-28 16:37:40 PDT
Created attachment 237329 [details]
patch
Comment 3 WebKit Commit Bot 2014-08-29 13:10:17 PDT
Comment on attachment 237329 [details]
patch

Clearing flags on attachment: 237329

Committed r173117: <http://trac.webkit.org/changeset/173117>
Comment 4 WebKit Commit Bot 2014-08-29 13:10:21 PDT
All reviewed patches have been landed.  Closing bug.