Bug 136318 - Enums in ScrollTypes and PlatformWheelEvent should not use uint64_t storage
Summary: Enums in ScrollTypes and PlatformWheelEvent should not use uint64_t storage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 15:38 PDT by Brian Burg
Modified: 2014-08-27 16:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.04 KB, patch)
2014-08-27 15:42 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-27 15:38:30 PDT 
It's wasteful.
Comment 1 Brian Burg 2014-08-27 15:42:13 PDT 
Created attachment 237265 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-27 15:44:55 PDT 
Attachment 237265 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ScrollTypes.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-08-27 16:29:39 PDT 
Comment on attachment 237265 [details]
Patch

Clearing flags on attachment: 237265

Committed r173034: <http://trac.webkit.org/changeset/173034>
Comment 4 WebKit Commit Bot 2014-08-27 16:29:41 PDT 
All reviewed patches have been landed.  Closing bug.