Bug 136281 - build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
Summary: build.webkit.org/dashboard: Poor performance when there are broken builds at ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-26 22:48 PDT by Alexey Proskuryakov
Modified: 2014-08-26 23:59 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (5.66 KB, patch)
2014-08-26 22:52 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
patch for landing (5.66 KB, patch)
2014-08-26 23:17 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-08-26 22:48:26 PDT 
For failing builds, the dashboard tries to figure out how long the build was broken. If it doesn't happen to have the data for an older passing build already loaded, it starts to load all historic results for this revision.

This is extremely costly, as there is an HTTP request for each iteration.
Comment 1 Alexey Proskuryakov 2014-08-26 22:52:05 PDT 
Created attachment 237205 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2014-08-26 22:58:16 PDT 
Builders are all shamelessly green, so I couldn't test the patch now :)
Comment 3 Tim Horton 2014-08-26 23:07:00 PDT 
Comment on attachment 237205 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=237205&action=review

> Tools/ChangeLog:10
> +        the iteration is already beaing loaded.

s/beaing/being/

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:111
> +                    queue.loadMoreHistoricIterations();

historic (adj.): "famous or important in history, or potentially so"

I think you want 'historical'. English is weird.
Comment 4 Alexey Proskuryakov 2014-08-26 23:17:59 PDT 
Created attachment 237208 [details]
patch for landing

Thanks!
Comment 5 WebKit Commit Bot 2014-08-26 23:59:04 PDT 
Comment on attachment 237208 [details]
patch for landing

Clearing flags on attachment: 237208

Committed r172998: <http://trac.webkit.org/changeset/172998>
Comment 6 WebKit Commit Bot 2014-08-26 23:59:06 PDT 
All reviewed patches have been landed.  Closing bug.