RESOLVED INVALID 136276
Subpixel layout: Rename pixelSnappedIntRect*() functions to roundedIntRect*(). 
https://bugs.webkit.org/show_bug.cgi?id=136276
Summary Subpixel layout: Rename pixelSnappedIntRect*() functions to roundedIntRect*().
zalan
Reported 2014-08-26 20:18:44 PDT
The term 'pixel snapping' is ambiguous. (CSS pixel vs. device pixel)
Attachments
Patch (91.06 KB, patch)
2014-08-26 20:29 PDT, zalan 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (991.12 KB, application/zip)
2014-08-26 21:56 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (953.08 KB, application/zip)
2014-08-26 22:34 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (953.77 KB, application/zip)
2014-08-26 23:38 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (950.82 KB, application/zip)
2014-08-27 00:32 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-08-26 20:29:28 PDT
Created attachment 237194 [details] Patch
Build Bot
Comment 2 2014-08-26 21:55:57 PDT
Comment on attachment 237194 [details] Patch Attachment 237194 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6747099794243584 New failing tests: svg/wicd/rightsizing-grid.xhtml svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Build Bot
Comment 3 2014-08-26 21:56:00 PDT
Created attachment 237202 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-08-26 22:34:29 PDT
Comment on attachment 237194 [details] Patch Attachment 237194 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6642936099897344 New failing tests: svg/wicd/rightsizing-grid.xhtml svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Build Bot
Comment 5 2014-08-26 22:34:32 PDT
Created attachment 237204 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-08-26 23:38:12 PDT
Comment on attachment 237194 [details] Patch Attachment 237194 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5834621107306496 New failing tests: svg/wicd/rightsizing-grid.xhtml svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Build Bot
Comment 7 2014-08-26 23:38:15 PDT
Created attachment 237209 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-08-27 00:32:31 PDT
Comment on attachment 237194 [details] Patch Attachment 237194 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4997083425669120 New failing tests: svg/wicd/rightsizing-grid.xhtml svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
Build Bot
Comment 9 2014-08-27 00:32:34 PDT
Created attachment 237214 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
zalan
Comment 10 2014-08-27 21:03:20 PDT
fixed in bug #136314
Note You need to log in before you can comment on or make changes to this bug.