Bug 136234 - Don't crash when the DataDetectors framework is unavailable.
Summary: Don't crash when the DataDetectors framework is unavailable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-25 15:00 PDT by Brady Eidson
Modified: 2014-08-25 15:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.68 KB, patch)
2014-08-25 15:05 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-08-25 15:00:05 PDT 
Don't crash when the DataDetectors framework is unavailable.

It's possible to run the same build of WebKit2 that expected DD.framework to be available in an environment that does not have it available.

In that environment, it should just early-return by skipping a whole bunch of work that is irrelevant.

In Radar - rdar://problem/18106066
Comment 1 Brady Eidson 2014-08-25 15:05:06 PDT 
Created attachment 237108 [details]
Patch v1
Comment 2 Tim Horton 2014-08-25 15:21:47 PDT 
Comment on attachment 237108 [details]
Patch v1

Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place?
Comment 3 Brady Eidson 2014-08-25 15:25:21 PDT 
(In reply to comment #2)
> (From update of attachment 237108 [details])
> Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place?

I couldn't find a way you'd end up in MenuUtilities with these in place.  I'll double check.
Comment 4 Brady Eidson 2014-08-25 15:31:25 PDT 
http://trac.webkit.org/changeset/172939