Bug 136203 - Reduce style marking when using the pseudo class :placeholder-shown
Summary: Reduce style marking when using the pseudo class :placeholder-shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-24 16:25 PDT by Benjamin Poulain
Modified: 2014-08-25 12:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.21 KB, patch)
2014-08-24 16:42 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (894.83 KB, application/zip)
2014-08-25 00:22 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-08-24 16:25:59 PDT
Reduce style marking when using the pseudo class :placeholder-shown
Comment 1 Benjamin Poulain 2014-08-24 16:42:54 PDT
Created attachment 237049 [details]
Patch
Comment 2 Darin Adler 2014-08-24 18:06:27 PDT
Comment on attachment 237049 [details]
Patch

Is there anyway to share code between those four different functions that all do variations on the same thing?
Comment 3 Benjamin Poulain 2014-08-24 18:24:36 PDT
(In reply to comment #2)
> (From update of attachment 237049 [details])
> Is there anyway to share code between those four different functions that all do variations on the same thing?

It's tricky, the compiler knows exactly what is going on with styling in order to optimize properly. I could easily templatize the marking section but IMHO that would only increase complexity.

Any opinion?
Comment 4 Build Bot 2014-08-25 00:22:39 PDT
Comment on attachment 237049 [details]
Patch

Attachment 237049 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5383619476455424

New failing tests:
compositing/checkerboard.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/adjacent-continuations-cause-assertion-failure.html
animations/animation-border-overflow.html
animations/3d/transform-origin-vs-functions.html
http/tests/appcache/abort-cache-onchecking.html
animations/3d/state-at-end-event-transform.html
animations/animation-add-events-in-handler.html
animations/animation-controller-drt-api.html
animations/additive-transform-animations.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
accessibility/alt-tag-on-image-with-nonimage-role.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 5 Build Bot 2014-08-25 00:22:41 PDT
Created attachment 237063 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Benjamin Poulain 2014-08-25 12:33:57 PDT
Comment on attachment 237049 [details]
Patch

Clearing flags on attachment: 237049

Committed r172933: <http://trac.webkit.org/changeset/172933>
Comment 7 Benjamin Poulain 2014-08-25 12:34:00 PDT
All reviewed patches have been landed.  Closing bug.