RESOLVED FIXED136203
Reduce style marking when using the pseudo class :placeholder-shown 
https://bugs.webkit.org/show_bug.cgi?id=136203
Summary Reduce style marking when using the pseudo class :placeholder-shown
Benjamin Poulain
Reported 2014-08-24 16:25:59 PDT
Reduce style marking when using the pseudo class :placeholder-shown
Attachments
Patch (8.21 KB, patch)
2014-08-24 16:42 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (894.83 KB, application/zip)
2014-08-25 00:22 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-08-24 16:42:54 PDT
Created attachment 237049 [details] Patch
Darin Adler
Comment 2 2014-08-24 18:06:27 PDT
Comment on attachment 237049 [details] Patch Is there anyway to share code between those four different functions that all do variations on the same thing?
Benjamin Poulain
Comment 3 2014-08-24 18:24:36 PDT
(In reply to comment #2) > (From update of attachment 237049 [details]) > Is there anyway to share code between those four different functions that all do variations on the same thing? It's tricky, the compiler knows exactly what is going on with styling in order to optimize properly. I could easily templatize the marking section but IMHO that would only increase complexity. Any opinion?
Build Bot
Comment 4 2014-08-25 00:22:39 PDT
Comment on attachment 237049 [details] Patch Attachment 237049 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5383619476455424 New failing tests: compositing/checkerboard.html compositing/bounds-in-flipped-writing-mode.html accessibility/adjacent-continuations-cause-assertion-failure.html animations/animation-border-overflow.html animations/3d/transform-origin-vs-functions.html http/tests/appcache/abort-cache-onchecking.html animations/3d/state-at-end-event-transform.html animations/animation-add-events-in-handler.html animations/animation-controller-drt-api.html animations/additive-transform-animations.html canvas/philip/tests/2d.clearRect+fillRect.basic.html http/tests/appcache/abort-cache-onchecking-resource-404.html accessibility/alt-tag-on-image-with-nonimage-role.html canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Build Bot
Comment 5 2014-08-25 00:22:41 PDT
Created attachment 237063 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Benjamin Poulain
Comment 6 2014-08-25 12:33:57 PDT
Comment on attachment 237049 [details] Patch Clearing flags on attachment: 237049 Committed r172933: <http://trac.webkit.org/changeset/172933>
Benjamin Poulain
Comment 7 2014-08-25 12:34:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.