Bug 136191 - Web Inspector: Do not copy large module source strings
Summary: Web Inspector: Do not copy large module source strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-22 19:24 PDT by Joseph Pecoraro
Modified: 2014-08-23 01:17 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.84 KB, patch)
2014-08-22 19:25 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-22 19:24:41 PDT 
We should use a non-copying WTFString constructor for the large inspector module strings:

    InjectedScriptSource_js
    CommandLineAPIModuleSource_js

Note, other compiled strings were not copied:

    XMLViewer_js
    XMLViewer_css
Comment 1 Radar WebKit Bug Importer 2014-08-22 19:25:36 PDT 
<rdar://problem/18109945>
Comment 2 Joseph Pecoraro 2014-08-22 19:25:48 PDT 
Created attachment 237021 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2014-08-23 01:17:05 PDT 
Comment on attachment 237021 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 237021

Committed r172888: <http://trac.webkit.org/changeset/172888>
Comment 4 WebKit Commit Bot 2014-08-23 01:17:08 PDT 
All reviewed patches have been landed.  Closing bug.