Bug 136142 - [Win] WebCore.proj is not copying WebKit resource files
Summary: [Win] WebCore.proj is not copying WebKit resource files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P1 Blocker
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-21 18:08 PDT by Brent Fulgham
Modified: 2014-08-21 18:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2014-08-21 18:11 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.47 KB, patch)
2014-08-21 18:13 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-08-21 18:08:59 PDT 
The WebCore project is where the English.lproj files are stored. These need to be included in the WebKit.resources file used by WebKit.dll. While the main WebKit.sln build properly copies these files, the stand-along MSBuild project "WebCore.proj" was not doing so.

This patch corrects this oversight.
Comment 1 Brent Fulgham 2014-08-21 18:09:24 PDT 
<rdar://problem/17733682>
Comment 2 Brent Fulgham 2014-08-21 18:11:16 PDT 
Created attachment 236950 [details]
Patch
Comment 3 Brent Fulgham 2014-08-21 18:13:37 PDT 
Created attachment 236952 [details]
Patch
Comment 4 Tim Horton 2014-08-21 18:18:33 PDT 
Comment on attachment 236952 [details]
Patch

rs=me
Comment 5 Brent Fulgham 2014-08-21 18:19:23 PDT 
Committed r172841: <http://trac.webkit.org/changeset/172841>