WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
136142
[Win] WebCore.proj is not copying WebKit resource files
https://bugs.webkit.org/show_bug.cgi?id=136142
Summary
[Win] WebCore.proj is not copying WebKit resource files
Brent Fulgham
Reported
2014-08-21 18:08:59 PDT
The WebCore project is where the English.lproj files are stored. These need to be included in the WebKit.resources file used by WebKit.dll. While the main WebKit.sln build properly copies these files, the stand-along MSBuild project "WebCore.proj" was not doing so. This patch corrects this oversight.
Attachments
Patch
(2.84 KB, patch)
2014-08-21 18:11 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(3.47 KB, patch)
2014-08-21 18:13 PDT
,
Brent Fulgham
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-08-21 18:09:24 PDT
<
rdar://problem/17733682
>
Brent Fulgham
Comment 2
2014-08-21 18:11:16 PDT
Created
attachment 236950
[details]
Patch
Brent Fulgham
Comment 3
2014-08-21 18:13:37 PDT
Created
attachment 236952
[details]
Patch
Tim Horton
Comment 4
2014-08-21 18:18:33 PDT
Comment on
attachment 236952
[details]
Patch rs=me
Brent Fulgham
Comment 5
2014-08-21 18:19:23 PDT
Committed
r172841
: <
http://trac.webkit.org/changeset/172841
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug