The Font Loader API disables page caching. As a first approximation, enable page caching when no font rules are currently loading, and the load() method has not been called.
Created attachment 236818 [details] Patch Prototype
Created attachment 237119 [details] Updated Prototype Updating the prototype. Feature is still toggled on for the bots, so this is not quite ready for review.
Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6648736453230592 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237123 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4796164855562240 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237127 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6023479409246208 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237128 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 237119 [details] Updated Prototype Attachment 237119 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5593205290565632 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237134 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 237155 [details] Updated Prototype
Created attachment 237237 [details] First Draft Removing feature enablement. This patch should be ready for review, but will not have the feature enabled yet.
Comment on attachment 237237 [details] First Draft Attachment 237237 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4723508772864000 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237241 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 237237 [details] First Draft Attachment 237237 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4684673678573568 New failing tests: fast/css/fontloader-page-cache.html
Created attachment 237276 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 237326 [details] Skipping test Added test must be skipped until feature is enabled
Comment on attachment 237326 [details] Skipping test View in context: https://bugs.webkit.org/attachment.cgi?id=237326&action=review r=me as the logic appears sound. > Source/WebCore/css/FontLoader.cpp:72 > + int familyCount() const { return m_numFamilies; } I'd call it m_familyCount for consistency. > Source/WebCore/css/FontLoader.h:104 > + unsigned m_rulesLoading; > + unsigned m_stringsLoading; Can we come up with some better names for these? m_stringsLoading is especially unobvious.
Created attachment 237518 [details] Incorporating feedback Incorporating feedback from kling. Renaming counts to m_numLoadingFromCSS and m_numLoadingFromJS.
Comment on attachment 237518 [details] Incorporating feedback Clearing flags on attachment: 237518 Committed r173209: <http://trac.webkit.org/changeset/173209>
All reviewed patches have been landed. Closing bug.