Bug 136025 – Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Brian Burg]

first refactoring!

[Radar WebKit Bug Importer]

<rdar://problem/18043994>

[Brian Burg]

Created attachment 236732 [details]
Patch

[WebKit Commit Bot]

Attachment 236732 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/models.py:139:  [Type.raw_name] Instance of 'Type' has no '_name' member  [pylint/E1101] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 236732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236732&action=review

r=me

> Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result:363
>  namespace Test {
> -class HappyName;
>  class ParameterBundle;
> +class UnpleasantName;
>  } // Test

You could get rid of the  UnpleasantName portion of this test if you wanted. Fine to leave it in though.

[Timothy Hatcher]

Comment on attachment 236732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236732&action=review

> Source/WebCore/inspector/protocol/DOM.json:100
> +            "id": "RGBAColor",

Just "Color" would be fine too. The object could have all manner of properties for any type of color if we wanted. It is RGBA if r, g, b, a is supplied. But it could be HSLA if we added optional h, s, l properties.

[Brian Burg]

Committed r172897: <http://trac.webkit.org/changeset/172897>