Bug 135977 - REGRESSION: Parts of the route/route options windows are invisible at maps.google.com
Summary: REGRESSION: Parts of the route/route options windows are invisible at maps.go...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-08-15 08:41 PDT by zalan
Modified: 2014-08-15 15:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.82 KB, patch)
2014-08-15 12:36 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-08-15 08:41:51 PDT 
Repro steps.

1. go to maps.google.com
2. set up a route between two locations
3. click Route Options
-> the other optional routes slide down, and it seems like part of the 'window' content that should be there disappears.
Comment 1 zalan 2014-08-15 08:42:03 PDT 
<rdar://problem/17961698>
Comment 2 Alexey Proskuryakov 2014-08-15 10:23:46 PDT 
Is this a duplicate of bug 42154?
Comment 3 Alexey Proskuryakov 2014-08-15 10:24:03 PDT 
Sorry, commented in a wrong bug.
Comment 4 zalan 2014-08-15 12:36:59 PDT 
Created attachment 236670 [details]
Patch
Comment 5 Andreas Kling 2014-08-15 12:57:26 PDT 
Comment on attachment 236670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236670&action=review

r=me

> Source/WebCore/rendering/style/RenderStyle.cpp:822
> +    if (isComposited && changeRequiresLayerRepaint(&style, changedContextSensitiveProperties))
> +        return changedContextSensitiveProperties & ContextSensitivePropertyClipRect;

Ideally this should probably cover more than just the clip rect case, but we can stick with a targeted fix for now.
Comment 6 WebKit Commit Bot 2014-08-15 15:44:04 PDT 
Comment on attachment 236670 [details]
Patch

Clearing flags on attachment: 236670

Committed r172656: <http://trac.webkit.org/changeset/172656>
Comment 7 WebKit Commit Bot 2014-08-15 15:44:08 PDT 
All reviewed patches have been landed.  Closing bug.