Bug 135861 - Generate WTFHeaderDetection.h and WebCoreHeaderDetection.h with CMake on Windows
Summary: Generate WTFHeaderDetection.h and WebCoreHeaderDetection.h with CMake on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-12 15:39 PDT by Alex Christensen
Modified: 2015-09-21 10:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2015-09-20 00:06 PDT, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-08-12 15:39:26 PDT
I implemented stubs in https://bugs.webkit.org/show_bug.cgi?id=135807 but that does not do the same checks as the Visual Studio build system does.  Someone with access to the AppleWin internal build system needs to add the needed behavior.
Comment 1 Alex Christensen 2015-09-20 00:06:31 PDT
Created attachment 261604 [details]
Patch
Comment 2 Brent Fulgham 2015-09-21 09:59:19 PDT
Comment on attachment 261604 [details]
Patch

r=me
Comment 3 Alex Christensen 2015-09-21 10:01:19 PDT
http://trac.webkit.org/changeset/190059