Bug 135829 - Add a fade transition to services highlights
Summary: Add a fade transition to services highlights
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-11 21:40 PDT by Tim Horton
Modified: 2014-08-12 13:05 PDT (History)
3 users (show)

See Also:


Attachments
patch (30.92 KB, patch)
2014-08-11 21:41 PDT, Tim Horton
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-08-11 21:40:16 PDT
<rdar://problem/17935736>
Comment 1 Tim Horton 2014-08-11 21:41:02 PDT
Created attachment 236427 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-12 00:24:43 PDT
Attachment 236427 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:170:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-08-12 13:05:44 PDT
http://trac.webkit.org/changeset/172483