Bug 135693 - Move multicol tests into fast/regions/multicol
Summary: Move multicol tests into fast/regions/multicol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 00:54 PDT by Iulia Tamas
Modified: 2014-08-07 05:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.22 KB, patch)
2014-08-07 01:07 PDT, Iulia Tamas 		no flags Details | Formatted Diff | Diff
Patch (7.80 KB, patch)
2014-08-07 01:10 PDT, Iulia Tamas 		no flags Details | Formatted Diff | Diff
Patch (8.17 KB, patch)
2014-08-07 01:26 PDT, Iulia Tamas 		no flags Details | Formatted Diff | Diff
Patch (7.76 KB, patch)
2014-08-07 04:12 PDT, Iulia Tamas 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iulia Tamas 2014-08-07 00:54:21 PDT 
Move multicol tests into fast/regions/multicol
Comment 1 Iulia Tamas 2014-08-07 01:07:43 PDT 
Created attachment 236178 [details]
Patch
Comment 2 Iulia Tamas 2014-08-07 01:10:51 PDT 
Created attachment 236179 [details]
Patch
Comment 3 Andrei Bucur 2014-08-07 01:17:29 PDT 
Comment on attachment 236179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236179&action=review

Good patch but the changelog needs some adjustments.

> LayoutTests/ChangeLog:7
> +

Please add a short description of the change for people reading the logs explaining this patch moves some tests.

> LayoutTests/ChangeLog:9
> +        * fast/regions/multicol-as-region-prevented.html: Removed.

Please list all the changed files, including the new ones.
Comment 4 Iulia Tamas 2014-08-07 01:26:54 PDT 
Created attachment 236180 [details]
Patch
Comment 5 Iulia Tamas 2014-08-07 04:12:20 PDT 
Created attachment 236184 [details]
Patch
Comment 6 Andrei Bucur 2014-08-07 04:16:24 PDT 
Comment on attachment 236184 [details]
Patch

r=me. Congrats for the first WebKit patch! \o/
Comment 7 WebKit Commit Bot 2014-08-07 05:09:12 PDT 
Comment on attachment 236184 [details]
Patch

Clearing flags on attachment: 236184

Committed r172207: <http://trac.webkit.org/changeset/172207>
Comment 8 WebKit Commit Bot 2014-08-07 05:09:15 PDT 
All reviewed patches have been landed.  Closing bug.