Bug 135501 - [CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
Summary: [CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-08-01 04:05 PDT by Carlos Garcia Campos
Modified: 2014-08-01 11:26 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.64 KB, patch)
2014-08-01 04:07 PDT, Carlos Garcia Campos 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-08-01 04:05:38 PDT 
It should be PROJECT_VERSION_MICRO instead.
Comment 1 Carlos Garcia Campos 2014-08-01 04:07:58 PDT 
Created attachment 235884 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-01 04:08:52 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gyuyoung Kim 2014-08-01 05:36:19 PDT 
Comment on attachment 235884 [details]
Patch

LGTM
Comment 4 Carlos Garcia Campos 2014-08-01 06:35:22 PDT 
Committed r171915: <http://trac.webkit.org/changeset/171915>
Comment 5 Martin Robinson 2014-08-01 11:26:48 PDT 
Comment on attachment 235884 [details]
Patch

Nice catch!