Bug 135482 - MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
Summary: MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Reported: 2014-07-31 17:02 PDT by Brent Fulgham
Modified: 2014-07-31 17:51 PDT (History)
0 users

See Also:

Patch (3.69 KB, patch)
2014-07-31 17:08 PDT, Brent Fulgham
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-07-31 17:02:41 PDT
You cannot enter Fullscreen mode for videos in a MiniBrowser WebKit2 window. This should be fixed!
Comment 1 Brent Fulgham 2014-07-31 17:08:31 PDT
Created attachment 235861 [details]
Comment 2 Tim Horton 2014-07-31 17:15:07 PDT
Comment on attachment 235861 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=235861&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:53
> +@property (nonatomic, setter=_setFullScreenEnabled:) BOOL _fullScreenIsEnabled;

no is plz
Comment 3 Brent Fulgham 2014-07-31 17:41:12 PDT
Landed in two patches:

Committed r171897 <http://trac.webkit.org/changeset/171897>.
Committed r171899 <http://trac.webkit.org/changeset/171899>.
Comment 4 Brent Fulgham 2014-07-31 17:51:55 PDT
One more -- i forgot to fix MinIBrowser itself:

Committed r171900 <http://trac.webkit.org/changeset/171900>.