Bug 135455 - [EFL] Add support for building with Geoclue2
Summary: [EFL] Add support for building with Geoclue2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 04:21 PDT by Carlos Alberto Lopez Perez
Modified: 2014-07-31 18:26 PDT (History)
11 users (show)

See Also:


Attachments
Build failure because of missing derived sources (4.36 KB, text/plain)
2014-07-31 04:23 PDT, Carlos Alberto Lopez Perez
no flags Details
After fixing the derived source issue, there is a second build failure due to missing includes. (1.48 KB, text/plain)
2014-07-31 04:24 PDT, Carlos Alberto Lopez Perez
no flags Details
Patch (3.34 KB, patch)
2014-07-31 04:32 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (484.43 KB, application/zip)
2014-07-31 05:35 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (533.23 KB, application/zip)
2014-07-31 06:01 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-07-31 04:21:44 PDT
When the system has installed the Geoclue2 libraries (package geoclue-2.0 on Debian/Ubuntu) USE_GEOCLUE2 will be enabled.

This will cause compilation failures on EFL due to missing derived sources and includes.
Comment 1 Carlos Alberto Lopez Perez 2014-07-31 04:23:30 PDT
Created attachment 235814 [details]
Build failure because of missing derived sources
Comment 2 Carlos Alberto Lopez Perez 2014-07-31 04:24:12 PDT
Created attachment 235815 [details]
After fixing the derived source issue, there is a second build failure due to missing includes.
Comment 3 Carlos Alberto Lopez Perez 2014-07-31 04:32:29 PDT
Created attachment 235817 [details]
Patch
Comment 4 Build Bot 2014-07-31 05:35:17 PDT
Comment on attachment 235817 [details]
Patch

Attachment 235817 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6386066789498880

New failing tests:
media/track/add-and-remove-track.html
Comment 5 Build Bot 2014-07-31 05:35:21 PDT
Created attachment 235820 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-07-31 06:01:23 PDT
Comment on attachment 235817 [details]
Patch

Attachment 235817 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4906511759310848

New failing tests:
media/track/add-and-remove-track.html
Comment 7 Build Bot 2014-07-31 06:01:31 PDT
Created attachment 235822 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Carlos Alberto Lopez Perez 2014-07-31 06:25:27 PDT
Cleared r- flag (Is just impossible that this has caused a failure on the layout test media/track/add-and-remove-track.html of the mac port. That should be some flaky test not marked as such)
Comment 9 Csaba Osztrogonác 2014-07-31 06:28:48 PDT
(In reply to comment #8)
> Cleared r- flag (Is just impossible that this has caused a failure on the layout test media/track/add-and-remove-track.html of the mac port. That should be some flaky test not marked as such)

Mac WK2 EWS is very flakey nowadays, see the webkit-dev thread for details.
Comment 10 Gyuyoung Kim 2014-07-31 17:52:27 PDT
Comment on attachment 235817 [details]
Patch

LGTM. Thanks.
Comment 11 WebKit Commit Bot 2014-07-31 18:26:34 PDT
Comment on attachment 235817 [details]
Patch

Clearing flags on attachment: 235817

Committed r171904: <http://trac.webkit.org/changeset/171904>
Comment 12 WebKit Commit Bot 2014-07-31 18:26:39 PDT
All reviewed patches have been landed.  Closing bug.