Bug 135447 - Default buttons do not pulse in OS X 10.10
Summary: Default buttons do not pulse in OS X 10.10
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-30 18:25 PDT by Dean Jackson
Modified: 2014-07-31 15:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.94 KB, patch)
2014-07-30 18:58 PDT, Dean Jackson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-07-30 18:25:03 PDT 
Default buttons do not pulse in OS X 10.10
Comment 1 Dean Jackson 2014-07-30 18:25:55 PDT 
OS X Yosemite does not need a redraw timer on RenderButton, since the default blue button for forms doesn't pulse in the manner of previous releases.
Comment 2 Dean Jackson 2014-07-30 18:58:31 PDT 
Created attachment 235797 [details]
Patch
Comment 3 mitz 2014-07-30 19:01:40 PDT 
Comment on attachment 235797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235797&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:2033
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101000
> +    return true;
> +#else
> +    return false;
> +#endif

We usually put the “present and future” case before the “legacy” case.
Comment 4 Dean Jackson 2014-07-30 19:17:06 PDT 
<rdar://problem/17577321>
Comment 5 Dean Jackson 2014-07-31 15:08:26 PDT 
Committed r171890: <http://trac.webkit.org/changeset/171890>