Bug 135407 - [EFL] Do not initialize g_type system explicitly in the ewk_init()
Summary: [EFL] Do not initialize g_type system explicitly in the ewk_init()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 21:05 PDT by Jinwoo Song
Modified: 2014-07-29 21:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2014-07-29 21:08 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-07-29 21:05:33 PDT 
EFL build requires glib version 2.38 but g_type_init() has been deprecated since version 2.36.
As the type system is initialized automatically since version 2.36, we do not need to call g_type_init() in the ewk_init().

https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#g-type-init
Comment 1 Jinwoo Song 2014-07-29 21:08:50 PDT 
Created attachment 235731 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-29 21:10:48 PDT 
Comment on attachment 235731 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2014-07-29 21:26:30 PDT 
Comment on attachment 235731 [details]
Patch

Clearing flags on attachment: 235731

Committed r171788: <http://trac.webkit.org/changeset/171788>
Comment 4 WebKit Commit Bot 2014-07-29 21:26:34 PDT 
All reviewed patches have been landed.  Closing bug.