Bug 135406 - Web Inspector: Only compute full ProfileNode times if needed
Summary: Web Inspector: Only compute full ProfileNode times if needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-29 20:33 PDT by Joseph Pecoraro
Modified: 2014-07-29 21:17 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.43 KB, patch)
2014-07-29 20:35 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-29 20:33:14 PDT 
* SUMMARY
Profiling the timeline a lot of time was spent inside ProfileNode computing each profile node's time information. Unfortunately this information is only used by Legacy Profiler views, and not used at all in the new Timeline view, so the computation is a complete waste.

We should only compute this information if needed.
Comment 1 Radar WebKit Bug Importer 2014-07-29 20:33:22 PDT 
<rdar://problem/17852395>
Comment 2 Joseph Pecoraro 2014-07-29 20:35:49 PDT 
Created attachment 235727 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-07-29 20:38:11 PDT 
Comment on attachment 235727 [details]
[PATCH] Proposed Fix

There is no clients if these getters! It was just over engineering of the API on my part before I added the time range computation. I see no harm keeping them as lazy getters though.
Comment 4 WebKit Commit Bot 2014-07-29 21:17:48 PDT 
Comment on attachment 235727 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235727

Committed r171787: <http://trac.webkit.org/changeset/171787>
Comment 5 WebKit Commit Bot 2014-07-29 21:17:51 PDT 
All reviewed patches have been landed.  Closing bug.