RESOLVED FIXED 135406
Web Inspector: Only compute full ProfileNode times if needed 
https://bugs.webkit.org/show_bug.cgi?id=135406
Summary Web Inspector: Only compute full ProfileNode times if needed
Joseph Pecoraro
Reported 2014-07-29 20:33:14 PDT
* SUMMARY Profiling the timeline a lot of time was spent inside ProfileNode computing each profile node's time information. Unfortunately this information is only used by Legacy Profiler views, and not used at all in the new Timeline view, so the computation is a complete waste. We should only compute this information if needed.
Attachments
[PATCH] Proposed Fix (3.43 KB, patch)
2014-07-29 20:35 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-29 20:33:22 PDT
<rdar://problem/17852395>
Joseph Pecoraro
Comment 2 2014-07-29 20:35:49 PDT
Created attachment 235727 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2014-07-29 20:38:11 PDT
Comment on attachment 235727 [details] [PATCH] Proposed Fix There is no clients if these getters! It was just over engineering of the API on my part before I added the time range computation. I see no harm keeping them as lazy getters though.
WebKit Commit Bot
Comment 4 2014-07-29 21:17:48 PDT
Comment on attachment 235727 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235727 Committed r171787: <http://trac.webkit.org/changeset/171787>
WebKit Commit Bot
Comment 5 2014-07-29 21:17:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.