RESOLVED FIXED 135405
Web Inspector: Reduce forced layouts in TimelineOverview 
https://bugs.webkit.org/show_bug.cgi?id=135405
Summary Web Inspector: Reduce forced layouts in TimelineOverview
Joseph Pecoraro
Reported 2014-07-29 20:26:05 PDT
* SUMMARY I am seeing forced layouts in TimelineOverview.prototype.updateLayout checking this._scrollContainer.offsetWidth. These seem unnecessary, as the scrollContainer did not change size at all. The container should only change if the ContentView changes size (window resize, sidebar expand/collapse), e.g. the normal ContentView.prototype.updateLayout.
Attachments
[PATCH] Proposed Fix (3.36 KB, patch)
2014-07-29 20:36 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-07-29 20:36:14 PDT
Created attachment 235728 [details] [PATCH] Proposed Fix
Radar WebKit Bug Importer
Comment 2 2014-07-29 20:36:32 PDT
<rdar://problem/17852407>
Timothy Hatcher
Comment 3 2014-07-29 20:46:53 PDT
Comment on attachment 235728 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=235728&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:224 > + updateLayoutForResize: function() Maybe we should/could start doing this in more places. Timeline is the first place is used updatLayout heavily to mean more than just resize.
WebKit Commit Bot
Comment 4 2014-07-29 21:00:58 PDT
Comment on attachment 235728 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235728 Committed r171786: <http://trac.webkit.org/changeset/171786>
WebKit Commit Bot
Comment 5 2014-07-29 21:01:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.