Bug 135405 - Web Inspector: Reduce forced layouts in TimelineOverview
Summary: Web Inspector: Reduce forced layouts in TimelineOverview
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2014-07-29 20:26 PDT by Joseph Pecoraro
Modified: 2014-07-29 21:01 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (3.36 KB, patch)
2014-07-29 20:36 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-29 20:26:05 PDT
I am seeing forced layouts in TimelineOverview.prototype.updateLayout checking this._scrollContainer.offsetWidth.

These seem unnecessary, as the scrollContainer did not change size at all. The container should only change if the ContentView changes size (window resize, sidebar expand/collapse), e.g. the normal ContentView.prototype.updateLayout.
Comment 1 Joseph Pecoraro 2014-07-29 20:36:14 PDT
Created attachment 235728 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2014-07-29 20:36:32 PDT
Comment 3 Timothy Hatcher 2014-07-29 20:46:53 PDT
Comment on attachment 235728 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235728&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:224
> +    updateLayoutForResize: function()

Maybe we should/could start doing this in more places. Timeline is the first place is used updatLayout heavily to mean more than just resize.
Comment 4 WebKit Commit Bot 2014-07-29 21:00:58 PDT
Comment on attachment 235728 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235728

Committed r171786: <http://trac.webkit.org/changeset/171786>
Comment 5 WebKit Commit Bot 2014-07-29 21:01:01 PDT
All reviewed patches have been landed.  Closing bug.