Bug 135384 - [TexMap] Move TextureMapperLayer::textureMapper() definition into the header
Summary: [TexMap] Move TextureMapperLayer::textureMapper() definition into the header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 06:46 PDT by Zan Dobersek
Modified: 2014-07-30 00:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2014-07-29 06:56 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-07-29 06:46:57 PDT 
[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
Comment 1 Zan Dobersek 2014-07-29 06:56:07 PDT 
Created attachment 235685 [details]
Patch
Comment 2 Martin Robinson 2014-07-29 10:05:12 PDT 
Comment on attachment 235685 [details]
Patch

Does this result in notable performance improvement. I ask because changes like these also increase code size.
Comment 3 Zan Dobersek 2014-07-29 14:04:13 PDT 
Inlining the two methods results in the generation of 7 instructions in total that crawl up the combined chain of effect targets and parent layers. I think this is a better alternative to the overhead of branching into a separate function and setting up the prologue and epilogue there.

This only affects three call sites, one of which was noticeably hot during the profiling. It's still only a small improvement, but comes at a minimal cost of increase in code size.
Comment 4 Zan Dobersek 2014-07-30 00:48:05 PDT 
Comment on attachment 235685 [details]
Patch

Clearing flags on attachment: 235685

Committed r171795: <http://trac.webkit.org/changeset/171795>
Comment 5 Zan Dobersek 2014-07-30 00:48:13 PDT 
All reviewed patches have been landed.  Closing bug.