RESOLVED FIXED135377
Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength 
https://bugs.webkit.org/show_bug.cgi?id=135377
Summary Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength
Martin Hodovan
Reported 2014-07-29 01:49:23 PDT
Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength
Attachments
Proposed patch (9.86 KB, patch)
2014-07-29 01:56 PDT, Martin Hodovan 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (495.34 KB, application/zip)
2014-07-29 09:04 PDT, Build Bot 		no flags
Details
Patch for landing (9.86 KB, patch)
2014-07-31 06:37 PDT, Martin Hodovan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Hodovan
Comment 1 2014-07-29 01:56:17 PDT
Created attachment 235671 [details] Proposed patch Patch by Timothy Loh, backported from Blink: https://codereview.chromium.org/71253002
Build Bot
Comment 2 2014-07-29 09:04:03 PDT
Comment on attachment 235671 [details] Proposed patch Attachment 235671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6253934939209728 New failing tests: storage/indexeddb/intversion-revert-on-abort.html
Build Bot
Comment 3 2014-07-29 09:04:06 PDT
Created attachment 235691 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Alexey Proskuryakov
Comment 4 2014-07-30 09:50:59 PDT
> storage/indexeddb/intversion-revert-on-abort.html This test was flaky yesterday; the offending patch has already been rolled out.
WebKit Commit Bot
Comment 5 2014-07-31 04:45:44 PDT
Comment on attachment 235671 [details] Proposed patch Rejecting attachment 235671 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 235671, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5254335390810112
Martin Hodovan
Comment 6 2014-07-31 06:37:03 PDT
Created attachment 235826 [details] Patch for landing
WebKit Commit Bot
Comment 7 2014-07-31 11:21:10 PDT
Comment on attachment 235826 [details] Patch for landing Clearing flags on attachment: 235826 Committed r171871: <http://trac.webkit.org/changeset/171871>
WebKit Commit Bot
Comment 8 2014-07-31 11:21:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.