RESOLVED FIXED135368
[iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy 
https://bugs.webkit.org/show_bug.cgi?id=135368
Summary [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
Benjamin Poulain
Reported 2014-07-28 16:32:10 PDT
[iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
Attachments
Patch (3.01 KB, patch)
2014-07-28 16:35 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-07-28 16:35:19 PDT
Created attachment 235639 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-28 16:37:43 PDT
Attachment 235639 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241: The parameter name "drawingArea" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-07-28 16:43:18 PDT
Comment on attachment 235639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235639&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1354 > + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea()) Aren't we in the WebKit namespace here? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241 > + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea()) Ditto.
Benjamin Poulain
Comment 4 2014-07-28 16:47:30 PDT
Comment on attachment 235639 [details] Patch Clearing flags on attachment: 235639 Committed r171709: <http://trac.webkit.org/changeset/171709>
Benjamin Poulain
Comment 5 2014-07-28 16:47:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.