Bug 135368 - [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
Summary: [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-28 16:32 PDT by Benjamin Poulain
Modified: 2014-07-28 16:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2014-07-28 16:35 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-07-28 16:32:10 PDT 
[iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
Comment 1 Benjamin Poulain 2014-07-28 16:35:19 PDT 
Created attachment 235639 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-28 16:37:43 PDT 
Attachment 235639 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241:  The parameter name "drawingArea" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-07-28 16:43:18 PDT 
Comment on attachment 235639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235639&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1354
> +        if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea())

Aren't we in the WebKit namespace here?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241
> +    if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea())

Ditto.
Comment 4 Benjamin Poulain 2014-07-28 16:47:30 PDT 
Comment on attachment 235639 [details]
Patch

Clearing flags on attachment: 235639

Committed r171709: <http://trac.webkit.org/changeset/171709>
Comment 5 Benjamin Poulain 2014-07-28 16:47:32 PDT 
All reviewed patches have been landed.  Closing bug.